Skip to content
Snippets Groups Projects
Commit 33f58a73 authored by Grießhaber Daniel's avatar Grießhaber Daniel :squid:
Browse files

fix build_model_input for OpenAI models to use same layout as the LLama models

parent b247f106
No related branches found
No related tags found
2 merge requests!2remove is_chat argument,!1Refactor models
...@@ -337,12 +337,9 @@ class OpenAI(LLMModel): ...@@ -337,12 +337,9 @@ class OpenAI(LLMModel):
messages: list[dict[str, str]], messages: list[dict[str, str]],
history: list[dict[str, str]] | None = None, history: list[dict[str, str]] | None = None,
): ):
return { if system_message is not None:
"prompt": prompt, prompt = system_message + prompt
"system_message": system_message, return {"prompt": prompt}, messages
"messages": messages,
"history": history,
}, messages
@classmethod @classmethod
def register_arguments(cls, parser: ArgumentParser): def register_arguments(cls, parser: ArgumentParser):
...@@ -367,6 +364,24 @@ class OpenAiChat(OpenAI): ...@@ -367,6 +364,24 @@ class OpenAiChat(OpenAI):
usage = ModelUsage(**response.usage.__dict__) usage = ModelUsage(**response.usage.__dict__)
return response_text, usage return response_text, usage
def build_model_input(
self,
prompt: str,
system_message: str | None,
messages: list[dict[str, str]],
history: list[dict[str, str]] | None = None,
):
# a history is prepended to the messages, and we assume that it also includes a system message, i.e., we never add a system message in this case
# TODO is it better to check for a system message in the history?
if history is not None:
messages = history + messages
[messages.insert(index, entry) for index, entry in enumerate(history)]
elif system_message:
messages = [self._get_system_message(system_message)] + messages
return {"messages": messages}, messages
argument_group = argument_parser.add_argument_group("Model arguments") argument_group = argument_parser.add_argument_group("Model arguments")
argument_group.add_argument( argument_group.add_argument(
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment