From 3d38933cc0f076ccb25c36af3ccc4b71539148f6 Mon Sep 17 00:00:00 2001
From: Peter <pt033@hdm-stuttgart.de>
Date: Sun, 24 Dec 2023 20:55:03 +0100
Subject: [PATCH] update(controller): change public FXML methods to private
---
...ce (conflicted copy 2023-12-23 155531).xml | 74 -------------------
.../Controller/CommunityMapController.java | 3 +-
.../Controller/LocalCreateController.java | 7 +-
.../Controller/MainMenuController.java | 16 ++--
.../Controller/MapForgeController.java | 12 ++-
.../Controller/MultiplayerController.java | 21 ++++--
.../MultiplayerCreateController.java | 3 +-
.../Controller/MultiplayerJoinController.java | 3 +-
.../Controller/PlayController.java | 21 ++++--
.../Controller/SettingsController.java | 16 ++--
.../Controller/SkinSelectionController.java | 14 ++--
11 files changed, 72 insertions(+), 118 deletions(-)
delete mode 100644 .idea/workspace (conflicted copy 2023-12-23 155531).xml
diff --git a/.idea/workspace (conflicted copy 2023-12-23 155531).xml b/.idea/workspace (conflicted copy 2023-12-23 155531).xml
deleted file mode 100644
index 24902c0f..00000000
--- a/.idea/workspace (conflicted copy 2023-12-23 155531).xml
+++ /dev/null
@@ -1,74 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<project version="4">
- <component name="AutoImportSettings">
- <option name="autoReloadType" value="SELECTIVE" />
- </component>
- <component name="ChangeListManager">
- <list default="true" id="b0fb4bdd-29b1-4f86-bd7c-f8c039cc32f2" name="Changes" comment="">
- <change beforePath="$PROJECT_DIR$/src/main/java/de/hdm_stuttgart/battlearena/Controller/MainMenuController.java" beforeDir="false" afterPath="$PROJECT_DIR$/src/main/java/de/hdm_stuttgart/battlearena/Controller/MainMenuController.java" afterDir="false" />
- <change beforePath="$PROJECT_DIR$/src/main/java/de/hdm_stuttgart/battlearena/Controller/MenuBorderPaneController.java" beforeDir="false" afterPath="$PROJECT_DIR$/src/main/java/de/hdm_stuttgart/battlearena/Controller/MenuBorderPaneController.java" afterDir="false" />
- <change beforePath="$PROJECT_DIR$/src/main/resources/fxml/MainMenu.fxml" beforeDir="false" afterPath="$PROJECT_DIR$/src/main/resources/fxml/MainMenu.fxml" afterDir="false" />
- <change beforePath="$PROJECT_DIR$/src/main/resources/fxml/MenuBorderPane.fxml" beforeDir="false" afterPath="$PROJECT_DIR$/src/main/resources/fxml/MenuBorderPane.fxml" afterDir="false" />
- <change beforePath="$PROJECT_DIR$/src/main/resources/fxml/Multiplayer.fxml" beforeDir="false" afterPath="$PROJECT_DIR$/src/main/resources/fxml/Multiplayer.fxml" afterDir="false" />
- <change beforePath="$PROJECT_DIR$/src/main/resources/styles/style.css" beforeDir="false" afterPath="$PROJECT_DIR$/src/main/resources/styles/style.css" afterDir="false" />
- </list>
- <option name="SHOW_DIALOG" value="false" />
- <option name="HIGHLIGHT_CONFLICTS" value="true" />
- <option name="HIGHLIGHT_NON_ACTIVE_CHANGELIST" value="false" />
- <option name="LAST_RESOLUTION" value="IGNORE" />
- </component>
- <component name="Git.Settings">
- <option name="RECENT_GIT_ROOT_PATH" value="$PROJECT_DIR$" />
- </component>
- <component name="MarkdownSettingsMigration">
- <option name="stateVersion" value="1" />
- </component>
- <component name="ProjectColorInfo">{
- "customColor": "",
- "associatedIndex": 5
-}</component>
- <component name="ProjectId" id="2Zs6XcL7ZlzU8xTNH2hOhkYjatb" />
- <component name="ProjectViewState">
- <option name="hideEmptyMiddlePackages" value="true" />
- <option name="showLibraryContents" value="true" />
- </component>
- <component name="PropertiesComponent">{
- "keyToString": {
- "RunOnceActivity.OpenProjectViewOnStart": "true",
- "RunOnceActivity.ShowReadmeOnStart": "true",
- "WebServerToolWindowFactoryState": "false",
- "git-widget-placeholder": "ui",
- "node.js.detected.package.eslint": "true",
- "node.js.detected.package.tslint": "true",
- "node.js.selected.package.eslint": "(autodetect)",
- "node.js.selected.package.tslint": "(autodetect)",
- "nodejs_package_manager_path": "npm",
- "vue.rearranger.settings.migration": "true"
- }
-}</component>
- <component name="RunManager">
- <configuration name="Main" type="Application" factoryName="Application">
- <option name="MAIN_CLASS_NAME" value="de.hdm_stuttgart.battlearena.Main.Main" />
- <module name="BattleArena" />
- <method v="2">
- <option name="Make" enabled="true" />
- </method>
- </configuration>
- </component>
- <component name="SpellCheckerSettings" RuntimeDictionaries="0" Folders="0" CustomDictionaries="0" DefaultDictionary="application-level" UseSingleDictionary="true" transferred="true" />
- <component name="TaskManager">
- <task active="true" id="Default" summary="Default task">
- <changelist id="b0fb4bdd-29b1-4f86-bd7c-f8c039cc32f2" name="Changes" comment="" />
- <created>1703198483742</created>
- <option name="number" value="Default" />
- <option name="presentableId" value="Default" />
- <updated>1703198483742</updated>
- <workItem from="1703198485662" duration="453000" />
- <workItem from="1703342937046" duration="2000" />
- </task>
- <servers />
- </component>
- <component name="TypeScriptGeneratedFilesManager">
- <option name="version" value="3" />
- </component>
-</project>
\ No newline at end of file
diff --git a/src/main/java/de/hdm_stuttgart/battlearena/Controller/CommunityMapController.java b/src/main/java/de/hdm_stuttgart/battlearena/Controller/CommunityMapController.java
index 7bb395b2..5c55a372 100644
--- a/src/main/java/de/hdm_stuttgart/battlearena/Controller/CommunityMapController.java
+++ b/src/main/java/de/hdm_stuttgart/battlearena/Controller/CommunityMapController.java
@@ -47,7 +47,8 @@ public class CommunityMapController implements Initializable {
// TODO: create map preview
- public void back() {
+ @FXML
+ private void back() {
parent.getChildren().clear();
parent.getChildren().add(new SceneLoader().loadScene("MapForge"));
}
diff --git a/src/main/java/de/hdm_stuttgart/battlearena/Controller/LocalCreateController.java b/src/main/java/de/hdm_stuttgart/battlearena/Controller/LocalCreateController.java
index 100c7ff1..ded22cff 100644
--- a/src/main/java/de/hdm_stuttgart/battlearena/Controller/LocalCreateController.java
+++ b/src/main/java/de/hdm_stuttgart/battlearena/Controller/LocalCreateController.java
@@ -28,13 +28,14 @@ public class LocalCreateController implements Initializable {
}
});
}
-
- public void playScene() {
+ @FXML
+ private void playScene() {
parent.getChildren().clear();
parent.getChildren().add(sceneLoader.loadScene("Play"));
}
- public void skinSelectionScene() {
+ @FXML
+ private void skinSelectionScene() {
parent.getChildren().clear();
parent.getChildren().add(sceneLoader.loadScene("SkinSelection"));
}
diff --git a/src/main/java/de/hdm_stuttgart/battlearena/Controller/MainMenuController.java b/src/main/java/de/hdm_stuttgart/battlearena/Controller/MainMenuController.java
index fb0530cc..21fb0595 100644
--- a/src/main/java/de/hdm_stuttgart/battlearena/Controller/MainMenuController.java
+++ b/src/main/java/de/hdm_stuttgart/battlearena/Controller/MainMenuController.java
@@ -22,22 +22,28 @@ public class MainMenuController implements Initializable {
parent.getChildren().add(sceneLoader.loadScene(name));
}
- public void playScene() {
+ @FXML
+ private void playScene() {
switchScene("Play");
}
- public void mapScene() {
+
+ @FXML
+ private void mapScene() {
switchScene("MapForge");
}
- public void statisticsScene() {
+ @FXML
+ private void statisticsScene() {
switchScene("Statistics");
}
- public void settingsScene() {
+ @FXML
+ private void settingsScene() {
switchScene("Settings");
}
- public void exit() {
+ @FXML
+ private void exit() {
Stage stage = (Stage) exitButton.getScene().getWindow();
stage.close();
}
diff --git a/src/main/java/de/hdm_stuttgart/battlearena/Controller/MapForgeController.java b/src/main/java/de/hdm_stuttgart/battlearena/Controller/MapForgeController.java
index a8da173b..db5ef303 100644
--- a/src/main/java/de/hdm_stuttgart/battlearena/Controller/MapForgeController.java
+++ b/src/main/java/de/hdm_stuttgart/battlearena/Controller/MapForgeController.java
@@ -12,7 +12,8 @@ public class MapForgeController {
private VBox parent;
SceneLoader sceneLoader = new SceneLoader();
- public void mapEditorScene() {
+ @FXML
+ private void mapEditorScene() {
try {
parent.getScene().setRoot(FXMLLoader.load(Objects.requireNonNull(getClass().getResource("/fxml/PlayerCreateScene.fxml"))));
MusicPlayerSingleton.getInstance().getMediaPlayer().dispose();
@@ -21,11 +22,13 @@ public class MapForgeController {
}
}
- public void communityMapScene() {
+ @FXML
+ private void communityMapScene() {
switchScene("CommunityMaps");
}
- public void updateMapScene() {
+ @FXML
+ private void updateMapScene() {
try {
parent.getScene().setRoot(FXMLLoader.load(Objects.requireNonNull(getClass().getResource("/fxml/PlayerCreateScene.fxml"))));
MusicPlayerSingleton.getInstance().getMediaPlayer().dispose();
@@ -34,7 +37,8 @@ public class MapForgeController {
}
}
- public void back() {
+ @FXML
+ private void back() {
switchScene("MainMenu");
}
diff --git a/src/main/java/de/hdm_stuttgart/battlearena/Controller/MultiplayerController.java b/src/main/java/de/hdm_stuttgart/battlearena/Controller/MultiplayerController.java
index 50587cc2..529c90c4 100644
--- a/src/main/java/de/hdm_stuttgart/battlearena/Controller/MultiplayerController.java
+++ b/src/main/java/de/hdm_stuttgart/battlearena/Controller/MultiplayerController.java
@@ -8,18 +8,23 @@ public class MultiplayerController {
private VBox parent;
private final SceneLoader sceneLoader = new SceneLoader();
- public void multiplayerCreateScene() {
- parent.getChildren().clear();
- parent.getChildren().add(sceneLoader.loadScene("MultiplayerCreate"));
+ @FXML
+ private void multiplayerCreateScene() {
+ switchScene("MultiplayerCreate");
}
- public void multiplayerJoinScene() {
- parent.getChildren().clear();
- parent.getChildren().add(sceneLoader.loadScene("MultiplayerJoin"));
+ @FXML
+ private void multiplayerJoinScene() {
+ switchScene("MultiplayerJoin");
+ }
+
+ @FXML
+ private void playScene() {
+ switchScene("Play");
}
- public void playScene() {
+ private void switchScene(String name) {
parent.getChildren().clear();
- parent.getChildren().add(sceneLoader.loadScene("Play"));
+ parent.getChildren().add(sceneLoader.loadScene(name));
}
}
diff --git a/src/main/java/de/hdm_stuttgart/battlearena/Controller/MultiplayerCreateController.java b/src/main/java/de/hdm_stuttgart/battlearena/Controller/MultiplayerCreateController.java
index 1e8a58b7..36432bb3 100644
--- a/src/main/java/de/hdm_stuttgart/battlearena/Controller/MultiplayerCreateController.java
+++ b/src/main/java/de/hdm_stuttgart/battlearena/Controller/MultiplayerCreateController.java
@@ -8,7 +8,8 @@ public class MultiplayerCreateController {
private VBox parent;
private final SceneLoader sceneLoader = new SceneLoader();
- public void multiplayerScene() {
+ @FXML
+ private void multiplayerScene() {
parent.getChildren().clear();
parent.getChildren().add(sceneLoader.loadScene("Multiplayer"));
}
diff --git a/src/main/java/de/hdm_stuttgart/battlearena/Controller/MultiplayerJoinController.java b/src/main/java/de/hdm_stuttgart/battlearena/Controller/MultiplayerJoinController.java
index 0e155a51..d5492991 100644
--- a/src/main/java/de/hdm_stuttgart/battlearena/Controller/MultiplayerJoinController.java
+++ b/src/main/java/de/hdm_stuttgart/battlearena/Controller/MultiplayerJoinController.java
@@ -8,7 +8,8 @@ public class MultiplayerJoinController {
private VBox parent;
private final SceneLoader sceneLoader = new SceneLoader();
- public void multiplayerScene() {
+ @FXML
+ private void multiplayerScene() {
parent.getChildren().clear();
parent.getChildren().add(sceneLoader.loadScene("Multiplayer"));
}
diff --git a/src/main/java/de/hdm_stuttgart/battlearena/Controller/PlayController.java b/src/main/java/de/hdm_stuttgart/battlearena/Controller/PlayController.java
index 96585537..24356b5c 100644
--- a/src/main/java/de/hdm_stuttgart/battlearena/Controller/PlayController.java
+++ b/src/main/java/de/hdm_stuttgart/battlearena/Controller/PlayController.java
@@ -8,18 +8,23 @@ public class PlayController {
private VBox parent;
private final SceneLoader sceneLoader = new SceneLoader();
- public void mainMenuScene() {
- parent.getChildren().clear();
- parent.getChildren().add(sceneLoader.loadScene("MainMenu"));
+ @FXML
+ private void mainMenuScene() {
+ switchScene("MainMenu");
}
- public void localScene() {
- parent.getChildren().clear();
- parent.getChildren().add(sceneLoader.loadScene("LocalCreate"));
+ @FXML
+ private void localScene() {
+ switchScene("LocalCreate");
+ }
+
+ @FXML
+ private void multiplayerScene() {
+ switchScene("Multiplayer");
}
- public void multiplayerScene() {
+ private void switchScene(String name) {
parent.getChildren().clear();
- parent.getChildren().add(sceneLoader.loadScene("Multiplayer"));
+ parent.getChildren().add(sceneLoader.loadScene(name));
}
}
diff --git a/src/main/java/de/hdm_stuttgart/battlearena/Controller/SettingsController.java b/src/main/java/de/hdm_stuttgart/battlearena/Controller/SettingsController.java
index fb1ab4be..d394ddc1 100644
--- a/src/main/java/de/hdm_stuttgart/battlearena/Controller/SettingsController.java
+++ b/src/main/java/de/hdm_stuttgart/battlearena/Controller/SettingsController.java
@@ -20,21 +20,23 @@ public class SettingsController implements Initializable {
public double music;
MusicPlayerSingleton musicPlayer = MusicPlayerSingleton.getInstance();
- public void creditScene() throws IOException {
+ @Override
+ public void initialize(URL url, ResourceBundle resourceBundle) {
+ setMusicVolume();
+ }
+
+ @FXML
+ private void creditScene() throws IOException {
parent.getChildren().clear();
parent.getScene().setRoot(FXMLLoader.load(Objects.requireNonNull(getClass().getResource("/fxml/credits.fxml"))));
}
- public void mainMenuScene() {
+ @FXML
+ private void mainMenuScene() {
parent.getChildren().clear();
parent.getChildren().add(sceneLoader.loadScene("MainMenu"));
}
- @Override
- public void initialize(URL url, ResourceBundle resourceBundle) {
- setMusicVolume();
- }
-
private void setMusicVolume() {
// need a runtime database to save volume
musicVolume.valueProperty().addListener((observableValue, oldValue, newValue) -> {
diff --git a/src/main/java/de/hdm_stuttgart/battlearena/Controller/SkinSelectionController.java b/src/main/java/de/hdm_stuttgart/battlearena/Controller/SkinSelectionController.java
index 89a93971..e753abdd 100644
--- a/src/main/java/de/hdm_stuttgart/battlearena/Controller/SkinSelectionController.java
+++ b/src/main/java/de/hdm_stuttgart/battlearena/Controller/SkinSelectionController.java
@@ -44,7 +44,14 @@ public class SkinSelectionController implements Initializable {
}
}
- public void gameScene() {
+ @FXML
+ private void back() {
+ parent.getChildren().clear();
+ parent.getChildren().add(new SceneLoader().loadScene("LocalCreate"));
+ }
+
+ @FXML
+ private void gameScene() {
try {
MusicPlayerSingleton.getInstance().getMediaPlayer().dispose();
parent.getScene().setRoot(FXMLLoader.load(Objects.requireNonNull(getClass().getResource("/fxml/GameScene.fxml"))));
@@ -52,9 +59,4 @@ public class SkinSelectionController implements Initializable {
throw new RuntimeException();
}
}
-
- public void back() {
- parent.getChildren().clear();
- parent.getChildren().add(new SceneLoader().loadScene("LocalCreate"));
- }
}
--
GitLab