From 171661401eea4822fc9455d17dbc45465b0a2ebd Mon Sep 17 00:00:00 2001
From: ys037 <ys037@hdm-stuttgart.de>
Date: Mon, 29 Jan 2024 01:10:34 +0100
Subject: [PATCH] Update: Classes for Clean Code #90
---
.../Controller/GameSceneController.java | 16 --------------
.../DataStorage/Classes/RuntimeInfo.java | 8 -------
.../Model/Entity/GameplayObjects/BigBomb.java | 5 -----
.../GameplayObjects/BigBombItemFrame.java | 5 -----
.../GameplayObjects/BlastUpItemFrame.java | 5 -----
.../Model/Entity/GameplayObjects/Bomb.java | 9 +-------
.../Entity/GameplayObjects/Explosion.java | 5 -----
.../Model/Entity/GameplayObjects/Heart.java | 5 -----
.../battlearena/Model/Entity/IEntity.java | 1 -
.../Model/Entity/NetworkPlayerTwo.java | 5 -----
.../battlearena/Model/Entity/Player.java | 22 ++-----------------
11 files changed, 3 insertions(+), 83 deletions(-)
diff --git a/src/main/java/de/hdm_stuttgart/battlearena/Controller/GameSceneController.java b/src/main/java/de/hdm_stuttgart/battlearena/Controller/GameSceneController.java
index ba5b5c9a..64bbcbdd 100644
--- a/src/main/java/de/hdm_stuttgart/battlearena/Controller/GameSceneController.java
+++ b/src/main/java/de/hdm_stuttgart/battlearena/Controller/GameSceneController.java
@@ -156,8 +156,6 @@ public class GameSceneController implements Initializable {
player.attack(enemy, graphicsContext2D);
enemy.attack(player, graphicsContext2D);
updateGameplayObjects();
- //updateExplosionspawns();
- player.checkGameplayExplosionInteraction(player,graphicsContext2D);
enemy.checkGameplayObjectInteraction(enemy, graphicsContext2D);
enemy.checkGameplayObjectInteraction(enemy, graphicsContext2D);
player.placeBomb(player, graphicsContext2D);
@@ -169,7 +167,6 @@ public class GameSceneController implements Initializable {
player.renderEntity(graphicsContext);
enemy.renderEntity(graphicsContext);
renderGameplayObjects(graphicsContext);
- //renderExplosionObjects(graphicsContext);
}
private void renderGameplayObjects(GraphicsContext graphicsContext) {
@@ -178,12 +175,6 @@ public class GameSceneController implements Initializable {
gameplayObject.renderEntity(graphicsContext);
}
}
- /*private void renderExplosionObjects(GraphicsContext graphicsContext) {
- List<IEntity> explosionSpawns = runtimeInfo.getExplosionspawns();
- for (IEntity explosionSpawn : explosionSpawns) {
- explosionSpawn.renderEntity(graphicsContext);
- }
- }*/
private void updateGameplayObjects() {
List<IEntity> gameplayObjects = runtimeInfo.getGameplayObjects();
@@ -192,13 +183,6 @@ public class GameSceneController implements Initializable {
runtimeInfo.setGameplayObjects(updateList);
log.debug("Gameplay objects updated");
}
- /*private void updateExplosionspawns() {
- List<IEntity> explosionspawns = runtimeInfo.getExplosionspawns();
- /*List<IEntity> updateList = explosionspawns.stream().filter(obj -> obj.getOBJECT_STATUS() != ObjectStatus.USED)
- .collect(Collectors.toList());*/
- /*runtimeInfo.setExplosionspawns(explosionspawns);
- log.debug("explosions objects updated");
- }*/
public IEntity getEnemy() {
return enemy;
diff --git a/src/main/java/de/hdm_stuttgart/battlearena/Model/DataStorage/Classes/RuntimeInfo.java b/src/main/java/de/hdm_stuttgart/battlearena/Model/DataStorage/Classes/RuntimeInfo.java
index 3f663421..fbb09802 100644
--- a/src/main/java/de/hdm_stuttgart/battlearena/Model/DataStorage/Classes/RuntimeInfo.java
+++ b/src/main/java/de/hdm_stuttgart/battlearena/Model/DataStorage/Classes/RuntimeInfo.java
@@ -121,14 +121,6 @@ public class RuntimeInfo {
this.gameplayObjects = gameplayObjects;
}
- public List<IEntity> getExplosionspawns() {
- return explosionspawns;
- }
-
- public void setExplosionspawns(List<IEntity> explosionspawns) {
- this.explosionspawns = explosionspawns;
- }
-
public String getMapDataGame() {
return mapDataGame;
}
diff --git a/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/GameplayObjects/BigBomb.java b/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/GameplayObjects/BigBomb.java
index 7076ad16..c2124e74 100644
--- a/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/GameplayObjects/BigBomb.java
+++ b/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/GameplayObjects/BigBomb.java
@@ -68,11 +68,6 @@ public class BigBomb implements IEntity {
}
- @Override
- public void checkGameplayExplosionInteraction(IEntity entity, GraphicsContext graphicsContext) {
-
- }
-
@Override
public void placeBomb(IEntity entity, GraphicsContext graphicsContext) {
diff --git a/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/GameplayObjects/BigBombItemFrame.java b/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/GameplayObjects/BigBombItemFrame.java
index cdc81bad..2bd11807 100644
--- a/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/GameplayObjects/BigBombItemFrame.java
+++ b/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/GameplayObjects/BigBombItemFrame.java
@@ -62,11 +62,6 @@ public class BigBombItemFrame implements IEntity {
}
- @Override
- public void checkGameplayExplosionInteraction(IEntity entity, GraphicsContext graphicsContext) {
-
- }
-
@Override
public void placeBomb(IEntity entity, GraphicsContext graphicsContext) {
diff --git a/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/GameplayObjects/BlastUpItemFrame.java b/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/GameplayObjects/BlastUpItemFrame.java
index 064218ea..28cec875 100644
--- a/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/GameplayObjects/BlastUpItemFrame.java
+++ b/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/GameplayObjects/BlastUpItemFrame.java
@@ -62,11 +62,6 @@ public class BlastUpItemFrame implements IEntity {
}
- @Override
- public void checkGameplayExplosionInteraction(IEntity entity, GraphicsContext graphicsContext) {
-
- }
-
@Override
public void placeBomb(IEntity entity, GraphicsContext graphicsContext) {
diff --git a/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/GameplayObjects/Bomb.java b/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/GameplayObjects/Bomb.java
index b6e94cd5..2049cc72 100644
--- a/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/GameplayObjects/Bomb.java
+++ b/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/GameplayObjects/Bomb.java
@@ -69,18 +69,11 @@ public class Bomb implements IEntity {
if (gameplayObject.getOBJECT_TYPE() == ObjectType.BLASTUP_ITEMFRAME) {
if (gameplayObject.getBoxCollider().intersects(boxCollider)) {
isBlastUpItemFrame = true;
- log.info("Collision with blastUpItemFrame");
- gameplayObject.setObjectStatus(ObjectStatus.USED);
}
}
}
}
- @Override
- public void checkGameplayExplosionInteraction(IEntity entity, GraphicsContext graphicsContext) {
-
- }
-
@Override
public void placeBomb(IEntity entity, GraphicsContext graphicsContext) {
@@ -117,7 +110,7 @@ public class Bomb implements IEntity {
frameCounter = 0;
}
}
- public int updateblastradius(int blastradius){ //TODO: It is not updating, return always 0?
+ public int updateblastradius(int blastradius){ //TODO: It is not updating, always returning 1?
if(isBlastUpItemFrame){
blastradius ++;
log.info("Upded blastradius:" + blastradius);
diff --git a/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/GameplayObjects/Explosion.java b/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/GameplayObjects/Explosion.java
index 819102f4..f43b573b 100644
--- a/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/GameplayObjects/Explosion.java
+++ b/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/GameplayObjects/Explosion.java
@@ -54,11 +54,6 @@ public class Explosion implements IEntity {
}
- @Override
- public void checkGameplayExplosionInteraction(IEntity entity, GraphicsContext graphicsContext) {
-
- }
-
@Override
public void placeBomb(IEntity entity, GraphicsContext graphicsContext) {
diff --git a/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/GameplayObjects/Heart.java b/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/GameplayObjects/Heart.java
index ea4b26fe..46b21ae5 100644
--- a/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/GameplayObjects/Heart.java
+++ b/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/GameplayObjects/Heart.java
@@ -54,11 +54,6 @@ public class Heart implements IEntity {
}
- @Override
- public void checkGameplayExplosionInteraction(IEntity entity, GraphicsContext graphicsContext) {
-
- }
-
@Override
public void placeBomb(IEntity entity, GraphicsContext graphicsContext) {
diff --git a/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/IEntity.java b/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/IEntity.java
index fd8287c0..275a1e4d 100644
--- a/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/IEntity.java
+++ b/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/IEntity.java
@@ -16,7 +16,6 @@ public interface IEntity {
//checks collision with GameplayObjects by iterating through GameplayObjects list
void checkGameplayObjectInteraction(IEntity entity, GraphicsContext graphicsContext);
- void checkGameplayExplosionInteraction(IEntity entity, GraphicsContext graphicsContext);
void placeBomb(IEntity entity, GraphicsContext graphicsContext);
diff --git a/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/NetworkPlayerTwo.java b/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/NetworkPlayerTwo.java
index 518b8bbb..a756382e 100644
--- a/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/NetworkPlayerTwo.java
+++ b/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/NetworkPlayerTwo.java
@@ -43,11 +43,6 @@ class NetworkPlayerTwo implements IEntity{
}
- @Override
- public void checkGameplayExplosionInteraction(IEntity entity, GraphicsContext graphicsContext) {
-
- }
-
@Override
public void placeBomb(IEntity entity, GraphicsContext graphicsContext) {
diff --git a/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/Player.java b/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/Player.java
index 02b173ba..c736dc1c 100644
--- a/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/Player.java
+++ b/src/main/java/de/hdm_stuttgart/battlearena/Model/Entity/Player.java
@@ -362,35 +362,17 @@ class Player implements IEntity {
log.info("Collision with blastUpItemFrame");
gameplayObject.setObjectStatus(ObjectStatus.USED);
}
- }
- if (gameplayObject.getOBJECT_TYPE() == ObjectType.EXPLOSION) {
+ } else if (gameplayObject.getOBJECT_TYPE() == ObjectType.EXPLOSION) {
if (gameplayObject.getBoxCollider().intersects(boxCollider)) {
- log.info("Collision with explosion");
+ log.debug("Collision with explosion");
gotHit(10);
}
}
- }
}
-
- @Override
- public void checkGameplayExplosionInteraction(IEntity entity, GraphicsContext graphicsContext) {
-
- }
-
- public int updateblastradius(int blastradius){
- if(isBlastUpItemFrame){
- blastradius ++;
- log.info("Upded blastradius:" + blastradius);
- isBlastUpItemFrame = false;
- return blastradius;
- }else {
- return blastradius;
- }
}
@Override
public void placeBomb(IEntity entity, GraphicsContext graphicsContext) {
- //blastradius = updateblastradius(blastradius);
List<IEntity> gameplayObjects = runtimeInfo.getGameplayObjects();
if (inputHandler.isBomb() && PLAYER_MODE == PlayerMode.PLAYER_ONE && bombPlacementRate == 0 ||
--
GitLab