From 12d98e9c60fd3b758f533dec88193d552eb85fa5 Mon Sep 17 00:00:00 2001 From: Martin Goik <goik@hdm-stuttgart.de> Date: Thu, 16 Jan 2025 21:01:41 +0100 Subject: [PATCH] Two Bugfixes --- .../java/de/hdm_stuttgart/mi/sd1/task1/D_SumTest.java | 7 +++++-- .../java/de/hdm_stuttgart/mi/sd1/task1/D_SumTest.java | 9 ++++++--- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/Klausuren/Sd1/2024summer/Exam/src/test/java/de/hdm_stuttgart/mi/sd1/task1/D_SumTest.java b/Klausuren/Sd1/2024summer/Exam/src/test/java/de/hdm_stuttgart/mi/sd1/task1/D_SumTest.java index 364c356a..c14da800 100644 --- a/Klausuren/Sd1/2024summer/Exam/src/test/java/de/hdm_stuttgart/mi/sd1/task1/D_SumTest.java +++ b/Klausuren/Sd1/2024summer/Exam/src/test/java/de/hdm_stuttgart/mi/sd1/task1/D_SumTest.java @@ -15,7 +15,10 @@ public class D_SumTest extends ExaminationTestDefaults { if (expected != actual) { final String errorMessage = "Expected " + expected + " == mitigatedSum(" + i + " , " + j + ") rather than »" + actual + "«. Wanna set a breakpoint for debugging?"; - Assert.assertEquals(errorMessage, D_Sum.mitigatedSum((byte)i, (byte) j)); // Yet again for debugging + + // Call again to allow for debugging + final byte actual2 = D_Sum.mitigatedSum(i, j); + Assert.fail(errorMessage); } } @@ -23,7 +26,7 @@ public class D_SumTest extends ExaminationTestDefaults { @Test public void test() { for (byte i = Byte.MIN_VALUE; i < ++i; ) { // ... i < BYTE.MAX_VALUE; i++ loops endlessly due to byte overflow - for (byte j = Byte.MIN_VALUE; j < j++; ) { + for (byte j = Byte.MIN_VALUE; j < ++j; ) { final int sum = i + j; if (sum < Byte.MIN_VALUE) { assertByteSum(Byte.MIN_VALUE, i, j); diff --git a/Klausuren/Sd1/2024summer/Solve/src/test/java/de/hdm_stuttgart/mi/sd1/task1/D_SumTest.java b/Klausuren/Sd1/2024summer/Solve/src/test/java/de/hdm_stuttgart/mi/sd1/task1/D_SumTest.java index 269a0119..c14da800 100644 --- a/Klausuren/Sd1/2024summer/Solve/src/test/java/de/hdm_stuttgart/mi/sd1/task1/D_SumTest.java +++ b/Klausuren/Sd1/2024summer/Solve/src/test/java/de/hdm_stuttgart/mi/sd1/task1/D_SumTest.java @@ -15,15 +15,18 @@ public class D_SumTest extends ExaminationTestDefaults { if (expected != actual) { final String errorMessage = "Expected " + expected + " == mitigatedSum(" + i + " , " + j + ") rather than »" + actual + "«. Wanna set a breakpoint for debugging?"; - Assert.assertEquals(errorMessage, D_Sum.mitigatedSum((byte)i, (byte) j)); // Yet again for debugging + + // Call again to allow for debugging + final byte actual2 = D_Sum.mitigatedSum(i, j); + Assert.fail(errorMessage); } } @Marking(points = 6) @Test public void test() { - for (byte i = Byte.MIN_VALUE; i < ++i; ) { - for (byte j = Byte.MIN_VALUE; j < j++; ) { + for (byte i = Byte.MIN_VALUE; i < ++i; ) { // ... i < BYTE.MAX_VALUE; i++ loops endlessly due to byte overflow + for (byte j = Byte.MIN_VALUE; j < ++j; ) { final int sum = i + j; if (sum < Byte.MIN_VALUE) { assertByteSum(Byte.MIN_VALUE, i, j); -- GitLab